issue/white-spaces-and-returns #12

Merged

verysmallrat merged 1 commit from charlie/cvsh:issue/white-spaces-and-returns into main

2026-08-08 11:50:07 +01:00

charlie commented

2026-08-07 05:28:01 +01:00

Owner

Syncing so it matches the available vpm package but I added return builtin that exits the current command handler and moves the config loading so it only happens for interactive sessions. This resolved a bug where using scp would conflict due to it always assuming a session is interactive; it isn't.

Added cvsh --version exit before touching the config and delegated all command-line invocations with arguments (except -v/--version) to /bin/sh so we can do things like cvsh -c 'echo hello' which solves another remote ssh issue - as previously it always assumed interactive for that too and wouldn't pass along -c command evocations when sending a command over ssh rather than doing an interactive session. I also moved all non-interactive stdin (e.g. pipes and redirected input) to /bin/sh to be written properly under the new style guide and intent-fully as the previous kept causing issues with non-interactive shells.

This resolved a number of bugs by treating /bin/sh which is inherent in busy-box as the fallback while we revise cvsh to handle non-interactive sessions properly.

Syncing so it matches the available `vpm` package but I added `return` builtin that exits the current command handler and moves the config loading so it only happens for interactive sessions. This resolved a bug where using `scp` would conflict due to it always assuming a session is interactive; it isn't. Added `cvsh --version` exit before touching the config and delegated all command-line invocations with arguments (_except -v/--version_) to /bin/sh so we can do things like `cvsh -c 'echo hello'` which solves another remote ssh issue - as previously it always assumed interactive for that too and wouldn't pass along `-c` command evocations when sending a command over ssh rather than doing an interactive session. I also moved all non-interactive stdin (e.g. pipes and redirected input) to /bin/sh to be written properly under the new style guide and intent-fully as the previous kept causing issues with non-interactive shells. This resolved a number of bugs by treating `/bin/sh` which is inherent in busy-box as the fallback while we revise cvsh to handle non-interactive sessions properly.

charlie added the

Kind/Feature

Kind/Enhancement

labels

2026-08-07 05:28:01 +01:00

charlie added 1 commit

2026-08-07 05:28:01 +01:00

issue/white-spaces-and-returns 049db76507

verysmallrat was assigned by charlie

2026-08-07 05:28:14 +01:00

charlie requested review from verysmallrat

2026-08-07 05:28:19 +01:00

charlie commented

2026-08-07 05:29:21 +01:00

Author

Owner

Assigned to @verysmallrat as I know they'll be doing a 3.5.11 taking over from this point now it's inline with the coding style-guide and setup for further development under the proposed plans while handling both interactive and non-interactive shells gracefully.

Assigned to @verysmallrat as I know they'll be doing a `3.5.11` taking over from this point now it's inline with the coding style-guide and setup for further development under the proposed plans while handling both interactive and non-interactive shells gracefully.