fix/cvsh-core #5

Merged

taylor merged 14 commits from verysmallrat/cvsh:fix/cvsh-core into main

2026-07-14 12:43:50 +01:00

verysmallrat commented

2026-07-14 12:40:24 +01:00

Member

Removed the reliance on 'sh' with execl, only to realise that we then lost a bunch of important functions.

So, I've rewritten all the important ones from scratch, including;

Pipes
Redirects including >, >>, <, 2>&1
Variable expansion
Globbing
Variable assignment
Command substitution, e.g. echo $(date)

Had to add lexing as well to do this properly, because otherwise we can't quote etc.

There is still cleanup to be done in terms of fixing unmatched quotes being a hard fail, as well as backslash escaping not... actually existing properly... I'll fix that one on another PR but I wanted to get this out by the time indev II released. Errrr, nothing else I think.

Removed the reliance on 'sh' with execl, only to realise that we then lost a bunch of important functions. So, I've rewritten all the important ones from scratch, including; - Pipes - Redirects including >, >>, <, 2>&1 - Variable expansion - Globbing - Variable assignment - Command substitution, e.g. echo $(date) Had to add lexing as well to do this properly, because otherwise we can't quote etc. There is still cleanup to be done in terms of fixing unmatched quotes being a hard fail, as well as backslash escaping not... actually existing properly... I'll fix that one on another PR but I wanted to get this out by the time indev II released. Errrr, nothing else I think.

verysmallrat added the

Kind/Enhancement

label

2026-07-14 12:40:24 +01:00

charlie was assigned by verysmallrat

2026-07-14 12:40:24 +01:00

taylor was assigned by verysmallrat

2026-07-14 12:40:24 +01:00

verysmallrat added 14 commits

2026-07-14 12:40:24 +01:00

rewrite of execute_command and reordering of functions to cleanup main logic + allow for proper forking without invoking sh 4545fc09f9

version number 9828926f37

fix double pwd bug 19069798ef

piping built, forking refactored 994f154374

fix recursive expand bug found in previous commit 9ea1e1a1b5

rewrite parsing (again) to pull it out of execution logic for extended featureset; >/>>/< redirects 16cded198b

lexing because we have to for quoting, globs, etc. quotes also 386e378eba

glob 2031d484cd

var expansion 02bd32a5b8

backgrounding processes ad9188127b

2> and 2>&1 redirecting 12f494c77a

cleanup of spacing, whitespaces, etc 9ad14ce2ed

var assignment 04c8cba744

command substitution af9d2b6a72

verysmallrat commented

2026-07-14 12:41:52 +01:00

Author

Member

Oh also I did a cleanup of a bunch of the code with whitespaces, double lines, etc. I probably caused a bunch of them myself while writing lol

Doubly also sorry this took me like, what, basically two weeks to write.

Oh also I did a cleanup of a bunch of the code with whitespaces, double lines, etc. I probably caused a bunch of them myself while writing lol Doubly also sorry this took me like, what, basically two weeks to write.

taylor merged commit 312dc525ef into main

2026-07-14 12:43:50 +01:00

taylor referenced this pull request from a commit

2026-07-14 12:43:50 +01:00

Merge pull request 'fix/cvsh-core' (!5) from verysmallrat/cvsh:fix/cvsh-core into main